fix(browser): ensure setup files are re-evaluated on each test run (fixes #8883) #8884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
yjaaidi
commented
Oct 30, 2025
| // if the mode is setup, we need to re-evaluate the setup file on each test run | ||
| if (mode === 'setup' || !hash) { | ||
| hash = Date.now().toString() | ||
| this.hashMap.set(filepath, hash) |
Contributor
Author
There was a problem hiding this comment.
Given we want to cache bust, is it useful to populate the hashMap when mode is setup?
| if (!hash) { | ||
|
|
||
| // if the mode is setup, we need to re-evaluate the setup file on each test run | ||
| if (mode === 'setup' || !hash) { |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is the right way but I tried to keep the change minimalistic.
sheremet-va
requested changes
Oct 31, 2025
test/browser/specs/runner.test.ts
Outdated
| const { exitCode } = await runBrowserTests({ | ||
| root: './fixtures/isolate-and-setup-file', | ||
| }) | ||
| expect(exitCode).toBe(0) |
Member
There was a problem hiding this comment.
this needs a check similar to line 284 that confirms the file actually did run
Contributor
Author
There was a problem hiding this comment.
✅ done
Oh! I didn't notice the who instances settings. Good to know 😊
Btw, expect.soft sounds like a better fit for failure analysis here. (I mean in these kind of exitCode + outputs checks)
Member
There was a problem hiding this comment.
That's a good point. We usually keep the error check first instead of the exitCode for that reason
sheremet-va
approved these changes
Oct 31, 2025
This was referenced Nov 3, 2025
yjaaidi
added a commit
to yjaaidi/analog
that referenced
this pull request
Dec 7, 2025
Vitest Browser Mode caches modules and does not re-execute side-effects. Therefore, when hooks are cleared, they are not set up again so TestBed is not reset after each test. There is an existing workaround to allow side-effects on setup files by not caching them (see vitest-dev/vitest#8884), but the behavior is not recursive so hooks that are registered as side effects in other files such as `@analogjs/vitest-angular/setup-testbed.ts` will not work. The solution is to register these hooks inside the `setUsetupTestBed` function. Closes analogjs#1994
yjaaidi
added a commit
to yjaaidi/analog
that referenced
this pull request
Dec 7, 2025
Vitest Browser Mode caches modules and does not re-execute side-effects. Therefore, when hooks are cleared, they are not set up again so TestBed is not reset after each test. There is an existing workaround to allow side-effects on setup files by not caching them (see vitest-dev/vitest#8884), but the behavior is not recursive so hooks that are registered as side effects in other files such as `@analogjs/vitest-angular/setup-testbed.ts` will not work. The solution is to register these hooks inside the `setUsetupTestBed` function. Closes analogjs#1994
yjaaidi
added a commit
to yjaaidi/analog
that referenced
this pull request
Dec 7, 2025
Vitest Browser Mode caches modules and does not re-execute side-effects. Therefore, when hooks are cleared, they are not set up again so TestBed is not reset after each test. Vitest was fixed to allow side-effects on setup files by not caching them (see vitest-dev/vitest#8884), but the behavior is not recursive so hooks that are registered as side effects in other files such as `@analogjs/vitest-angular/setup-testbed.ts` will not work. The solution is to register these hooks inside the `setUsetupTestBed` function. Closes analogjs#1994
yjaaidi
added a commit
to yjaaidi/analog
that referenced
this pull request
Dec 8, 2025
Vitest Browser Mode caches modules and does not re-execute side-effects. Therefore, when hooks are cleared, they are not set up again so TestBed is not reset after each test. Vitest was fixed to allow side-effects on setup files by not caching them (see vitest-dev/vitest#8884), but the behavior is not recursive so hooks that are registered as side effects in other files such as `@analogjs/vitest-angular/setup-testbed.ts` will not work. The solution is to register these hooks inside the `setUsetupTestBed` function. Closes analogjs#1994
brandonroberts
pushed a commit
to analogjs/analog
that referenced
this pull request
Dec 8, 2025
Vitest Browser Mode caches modules and does not re-execute side-effects. Therefore, when hooks are cleared, they are not set up again so TestBed is not reset after each test. Vitest was fixed to allow side-effects on setup files by not caching them (see vitest-dev/vitest#8884), but the behavior is not recursive so hooks that are registered as side effects in other files such as `@analogjs/vitest-angular/setup-testbed.ts` will not work. The solution is to register these hooks inside the `setUsetupTestBed` function. Closes #1994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8883
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.