fix(coverage): handle query param based transforms correctly #8418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
commented
Aug 10, 2025
| // we are using a normalized file name by default because this is what | ||
| // Vite expects in the source maps handler | ||
| filename: module.file || filename, | ||
| filename: module.id, |
There was a problem hiding this comment.
The module.file || filename did not contain query params. module.id does. We need to have the query present in vm.RunningCodeOptions.filename so that V8 reports those files properly. Otherwise we would see same file URL multiple times, and could not identify which coverage belongs to which file transform.
Before:
{
scriptId: '305',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts',
functions: [...]
}
{
scriptId: '306',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts',
functions: [...]
}
{
scriptId: '307',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts',
functions: [...]
}After:
{
scriptId: '305',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts',
functions: [...]
}
{
scriptId: '306',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts%3Fquery=first',
functions: [...]
}
{
scriptId: '307',
url: 'file:///Users/ari/Git/vitest/test/coverage-test/fixtures/src/query-param-transformed.ts%3Fquery=second',
functions: [...]
}Note that the offset of functions there maps to different positions, based on query params.
14e2423 to
9d43490
Compare
@vitest/browser
@vitest/coverage-istanbul
@vitest/coverage-v8
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
6 tasks
|
Marking #6029 as linked too, as the minimal reproduction seems to work properly with this fix. I guess the auto-import does something with query params. |
Closed
6 tasks
sheremet-va
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.