Skip to content

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Aug 25, 2025

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 506f216
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68ac8f79a5ea690008380757
😎 Deploy Preview https://deploy-preview-8477--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines +5 to +6
test('custom `viteOverrides.plugins` work with `vitest:coverage-transform` plugin (#8468)', async () => {
const viteOverrides = { plugins: [customFilePlugin('1')] }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the fix this test fails expectedly as:

@AriPerkkio AriPerkkio marked this pull request as ready for review August 26, 2025 08:17
@sheremet-va sheremet-va merged commit ff5170c into vitest-dev:main Aug 26, 2025
12 of 14 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-transform-order branch August 26, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in testing vue x istanbul coverage via Node APIs
2 participants