perf: don't set process.title
#8453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
approved these changes
Aug 19, 2025
|
Minimal repros without Vitest: const startTime = performance.now();
process.title = "node (example)";
console.log(`${(performance.now() - startTime).toFixed(2)} ms`);
// 12-15ms, Apple M2 Air 16BGInside import { fork } from "node:child_process";
import { fileURLToPath } from "node:url";
const SET_NAME = process.env.SET_NAME;
const isMainThread = process.send === undefined;
if (isMainThread) {
const startTime = performance.now();
const subprocess = fork(fileURLToPath(import.meta.url));
subprocess.on("exit", () => console.log(`${(performance.now() - startTime).toFixed(2)} ms`));
} else {
if (SET_NAME) {
process.title = "node (example)";
}
}$ node ./example.mjs
26.50 ms
$ node ./example.mjs
27.05 ms
$ node ./example.mjs
26.66 ms
$ SET_NAME=1 node ./example.mjs
40.38 ms
$ SET_NAME=1 node ./example.mjs
39.52 ms
$ SET_NAME=1 node ./example.mjs
38.79 msUsing import { fork } from "node:child_process";
import { fileURLToPath } from "node:url";
const isMainThread = process.send === undefined;
if (isMainThread) {
const startTime = performance.now();
const subprocess = fork(fileURLToPath(import.meta.url), undefined, { execArgv: ["--title=node (example)"]});
subprocess.on("exit", () => console.log(`${(performance.now() - startTime).toFixed(2)} ms`));
} else {
// Child process running
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
process.titletakes 10ms on my machine (MacBook Pro) and 20ms on @AriPerkkio's machine. We are considering removing this call to improve performance.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.