Skip to content

fix(jsdom): override globals that Fetch API relies on #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

fix(jsdom): override globals that Fetch API relies on #8390

merged 2 commits into from
Aug 6, 2025
+47 −13

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Aug 5, 2025 •
edited
Loading

Description

Fixes #8374
Fixes #7906

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Aug 5, 2025

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit e44dfdc
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6891fc157505f30008268c6a
😎 Deploy Preview https://deploy-preview-8390--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa
hi-ogawa previously approved these changes Aug 6, 2025
View reviewed changes
@sheremet-va sheremet-va merged commit 05b4178 into vitest-dev:main Aug 6, 2025
14 checks passed
@sheremet-va sheremet-va deleted the fix/override-fetch-api branch August 6, 2025 15:59
matej-pavlik added a commit to matej-pavlik/school-vavjs that referenced this pull request Aug 7, 2025
@matej-pavlik
test: fix tests failing in node v22.15 and above
7cda522 
The error originates from Vitest when used with jsdom. See vitest-dev/vitest#7906 for more details. This issue is fixed in vitest-dev/vitest#8390, but not yet released.
@parker-badgeinc
Copy link

Sorry to bump this @sheremet-va. Is there any way we could get this added into the next release? Seems like it's currently slotted for the v4 release. Not sure the timeline on when v4 will be released, so this may not be important enough.

@sheremet-va
Copy link
Member Author

Sorry to bump this @sheremet-va. Is there any way we could get this added into the next release? Seems like it's currently slotted for the v4 release. Not sure the timeline on when v4 will be released, so this may not be important enough.

You can use Vitest 4 beta to test this.

@prscoelho prscoelho mentioned this pull request Sep 11, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sheremet-va @parker-badgeinc @hi-ogawa