Skip to content

fix(browser): await mocker invalidation to avoid race condition with "mock wasn't registered" #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 3 commits into from
May 28, 2025
Merged

fix(browser): await mocker invalidation to avoid race condition with "mock wasn't registered" #8021

sheremet-va merged 3 commits into from
May 28, 2025

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented May 23, 2025

Description

Fixes #7912
Fixes #7944

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented May 23, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 4187911
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/683487e9c13a020008d3ca01
😎 Deploy Preview https://deploy-preview-8021--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va mentioned this pull request May 26, 2025
Closed
6 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 26, 2025 •
edited
Loading

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@8021

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@8021

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@8021

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@8021

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@8021

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@8021

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@8021

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@8021

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@8021

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@8021

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@8021

vite-node

npm i https://pkg.pr.new/vite-node@8021

vitest

npm i https://pkg.pr.new/vitest@8021

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@8021

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@8021

commit: 4187911

@sheremet-va sheremet-va merged commit b34ffad into vitest-dev:main May 28, 2025
13 of 14 checks passed
@sheremet-va sheremet-va deleted the fix/browser-await-interceptor branch May 28, 2025 13:58
@sheremet-va sheremet-va mentioned this pull request May 30, 2025
Closed
6 tasks
@renovate renovate bot mentioned this pull request Sep 15, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

1 participant

@sheremet-va