-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(browser): support iframe locator with playwright provider #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(browser): support iframe locator with playwright provider #8016
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @sheremet-va, I'd like to work on supporting Does it need to be done at the framework adapter level? I promise I won't just do a PR with AI slop 😄 . |
The locator support is provided via ivya package. The implementation should work the same way as playwright. Playwright does support Basically, to make const frame = page.frameLocator(page.getByTestId('iframe'))
frame.getByText('Hello World').element() // right now fails |
Description
Fixes #6966
This PR supports iframe user events, bu doesn't support
expect
assertions because they rely on walking the DOM and not CDP.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.