Skip to content

feat(browser): support actionTimeout as playwright provider options #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 5 commits into from
Dec 1, 2024
Merged

feat(browser): support actionTimeout as playwright provider options #6984

sheremet-va merged 5 commits into from
Dec 1, 2024

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 29, 2024 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Nov 29, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ef968b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67491dea50de770008b3fc7f
😎 Deploy Preview https://deploy-preview-6984--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review November 29, 2024 02:18
sheremet-va
sheremet-va approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@sheremet-va sheremet-va left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this in the docs. I am adding a new page titled "Configuring Playwright" in #6975 - I will add it there

@sheremet-va sheremet-va merged commit e2c29ea into vitest-dev:main Dec 1, 2024
16 of 17 checks passed
@sheremet-va sheremet-va added this to the 2.2.0 milestone Dec 1, 2024
@hi-ogawa hi-ogawa deleted the feat-playwright-actionTimeout branch December 2, 2024 00:09
@sheremet-va sheremet-va modified the milestones: 2.2.0, 3.0.0 Dec 5, 2024
@hi-ogawa hi-ogawa mentioned this pull request Dec 16, 2024
Closed
6 tasks