Skip to content

fix(css): resolve relative paths in sass, revert #20300 #20349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

fix(css): resolve relative paths in sass, revert #20300 #20349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a4016
fix(css): resolve relative paths in sass, revert #20300
sapphi-red Jul 4, 2025
4febd02
test: fix alias
sapphi-red Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 19 additions & 28 deletions packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2433,31 +2433,23 @@ const makeScssWorker = (
return unquotedUrl.startsWith('#{')
}

const createInternalImporter = (
isForRelative: boolean,
): Sass.Importer<'async'> => ({
const internalImporter: Sass.Importer<'async'> = {
async canonicalize(url, context) {
if (isForRelative) {
// sass passes resolved paths for importer passed to `importer` option
const resolved = new URL(url, context.containingUrl ?? undefined)
if (fs.existsSync(resolved)) return resolved
} else {
const importer = context.containingUrl
? fileURLToPath(context.containingUrl)
: options.filename
const resolved = await resolvers.sass(
environment,
url,
cleanScssBugUrl(importer),
)
if (
resolved &&
(resolved.endsWith('.css') ||
resolved.endsWith('.scss') ||
resolved.endsWith('.sass'))
) {
return pathToFileURL(resolved)
}
const importer = context.containingUrl
? fileURLToPath(context.containingUrl)
: options.filename
const resolved = await resolvers.sass(
environment,
url,
cleanScssBugUrl(importer),
)
if (
resolved &&
(resolved.endsWith('.css') ||
resolved.endsWith('.scss') ||
resolved.endsWith('.sass'))
) {
return pathToFileURL(resolved)
}
return null
},
Expand All @@ -2480,13 +2472,12 @@ const makeScssWorker = (
result.contents ?? (await fsp.readFile(result.file, 'utf-8'))
return { contents, syntax, sourceMapUrl: canonicalUrl }
},
})

}
sassOptions.importers = [
...(sassOptions.importers ?? []),
createInternalImporter(false),
internalImporter,
]
sassOptions.importer ??= createInternalImporter(true)
sassOptions.importer ??= internalImporter

const result = await compiler.compileStringAsync(data, sassOptions)
return {
Expand Down
2 changes: 1 addition & 1 deletion playground/css/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default defineConfig({
resolve: {
alias: [
{ find: '=', replacement: __dirname },
{ find: /=replace\/(.*)/, replacement: `${__dirname}/$1` },
{ find: /^=replace\/(.*)/, replacement: `${__dirname}/$1` },
{ find: 'spacefolder', replacement: __dirname + '/folder with space' },
{ find: '#alias', replacement: __dirname + '/aliased/foo.css' },
{
Expand Down