Skip to content

Conversation

@Davidson-Souza
Copy link
Member

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

Description

Until now, only the running_node could reply to user request. However, that's cumbersome and limiting. After this commit, both sync_node and chain_selector can handle user requests made from the handle.

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@Davidson-Souza Davidson-Souza added enhancement New feature or request chore Cleaning, refactoring, reducing complexity labels Mar 7, 2025
Copy link
Collaborator

@jaoleal jaoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good opportunity to add docs for these functions.

Here some suggestions to see if my intuition about them are right.

Ill be locally testing them.

@Davidson-Souza Davidson-Souza marked this pull request as ready for review March 10, 2025 18:20
Until now, only the running_node could reply to user request. However,
that's cumbersome and limiting. After this commit, both sync_node and
chain_selector can handle user requests made from the handle.
@Davidson-Souza Davidson-Souza merged commit 72233b9 into vinteumorg:master Mar 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Cleaning, refactoring, reducing complexity enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants