Added test for getblockheader JSONRPC call #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add a structure to test calls of `getblockheader` in tests/test_framework/floresta_rpc.py, a simple test in tests/floresta_cli_getblockheader.py and a helper in pyproject.toml as `florestacli-getblockheader-test`. This simple test just call the `getblockheader` with the hash of regtest's genesis block and expect, among some data, a prev_blockhash full of zeros.
|
ACK 9a457dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for #252
What is the purpose of this pull request?
Which crates are being modified?
Description
This PR add a structure to test calls of
getblockheaderintests/test_framework/floresta_rpc.py, a simple test intests/floresta_cli_getblockheader.pyand a helper in pyproject.toml asflorestacli-getblockheader-test.This simple test just call the
getblockheaderwith the hash of regtest's genesis block and expect, among some data, a prev_blockhash full of zeros.Notes to the reviewers
It's important to note that this PR can be closely related to PR #391.
Checklist
just lintcargo test