consensus: fix a problem with script sizes #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
JoseSK999
approved these changes
Mar 5, 2025
A output's script may be bigger than 10k bytes, it just can't be spent. We incorrectly check the script pubkey size when it gets created, causing floresta to break out of consensus if such an output is mined. Fixes vinteumorg#393
317b17e to
9a7e4c6
Compare
Yes! It could be created, but never spent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
A output's script may be bigger than 10k bytes, it just can't be spent. We incorrectly check the script pubkey size when it gets created, causing floresta to break out of consensus if such an output is mined.
Fixes #393
Notes to the reviewers
Tests for this will be integrated on #387
Checklist
just lintcargo test