Skip to content

Conversation

@JoseSK999
Copy link
Contributor

Description

Our current cache version appears empty. This is because the first weeks of the year have a leading zero (e.g. 09), so bash was interpreting it as octal-base. This is fixed with the #10 prefix.

Also removed the cache-keys id as it's not used in fuzz.yml.

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: CI fix

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .github

The first weeks of the year have a leading zero (e.g. 09), so bash was interpreting it as octal-base. This is fixed with the 'vinteumorg#10' prefix.

Removed the `cache-keys` id as it's not used in `fuzz.yml`.
@JoseSK999 JoseSK999 force-pushed the fix-ci-cache-version branch from cf4e9f0 to 3043ef5 Compare March 3, 2025 11:54
@JoseSK999
Copy link
Contributor Author

In the commit message #10 is displayed as vinteumorg#10, but should be read as #10

@Davidson-Souza
Copy link
Member

Nice! I did notice something weird with the cache names, but I wasn't sure what caused it.

ACK 3043ef5

@Davidson-Souza Davidson-Souza merged commit 0c15d67 into vinteumorg:master Mar 3, 2025
7 checks passed
@JoseSK999 JoseSK999 deleted the fix-ci-cache-version branch March 3, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants