build: ensure dev tools available on PATH #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Cc @jaoleal |
jaoleal
suggested changes
Feb 28, 2025
Collaborator
jaoleal
left a comment
There was a problem hiding this comment.
Hi! Nice catch... I use nixos(btw) and all that i wrote to be imported inside the dev shell i alredy have on my machine.
Nice to see another nix user in this repo! I was felling lonely 😆
Collaborator
|
ACK 6f4c28a |
jaoleal
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
I noticed that the developer tools are not being added to the default developer shell. I solved this by adding them to
nativeBuildInputs, but I am relatively new to nix and am not sure this is the best pattern.Checklist
just lintcargo test