Skip to content

Conversation

@JoseSK999
Copy link
Contributor

We weren't checking the coinbase output script limits, so added them to verify_coinbase. Also checking that the coinbase tx has a single input.

Plus minor style changes (I think the coinbase reward check is more readable now)

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: Missing consensus checks

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

@jaoleal
Copy link
Collaborator

jaoleal commented Feb 26, 2025

ACK

@JoseSK999 JoseSK999 force-pushed the check-coinbase-outputs branch from ad85a51 to ca968ab Compare February 26, 2025 20:05
@JoseSK999
Copy link
Contributor Author

Fixed clippy

@Davidson-Souza
Copy link
Member

ACK ca968ab

@Davidson-Souza Davidson-Souza merged commit 85ab91d into vinteumorg:master Feb 26, 2025
7 checks passed
@JoseSK999 JoseSK999 deleted the check-coinbase-outputs branch February 26, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants