Skip to content

doc: add floresta-cli PATH installation command to README #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

doc: add floresta-cli PATH installation command to README #377

merged 1 commit into from
Feb 17, 2025

Conversation

@luisschwab
Copy link
Contributor

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: Documentation

Description

Added instructions to install floresta-cli to PATH

Notes to the reviewers

N/A

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@luisschwab luisschwab mentioned this pull request Feb 17, 2025
Closed
21 tasks
@jaoleal
Copy link
Collaborator

jaoleal commented Feb 17, 2025

Concept ACK. Isnt better to use 'cargo install' with the '--bin' flag instead of the '--path' ?

@luisschwab
Copy link
Contributor Author

Isnt better to use 'cargo install' with the '--bin' flag instead of the '--path' ?

No, because

$ cargo install --bin floresta-cli
error: Using `cargo install` to install the binaries for the package in current working directory is no longer supported, use `cargo install --path .` instead. Use `cargo build` if you want to simply build the package.

@jaoleal
Copy link
Collaborator

jaoleal commented Feb 17, 2025

Oh, fine.

@Davidson-Souza Davidson-Souza merged commit c402fbc into vinteumorg:master Feb 17, 2025
14 checks passed
@luisschwab luisschwab deleted the docs/install-floresta-cli branch June 25, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luisschwab @jaoleal @Davidson-Souza