code quality:Fix code simplification clippy warnings #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
requested changes
Feb 8, 2025
jaoleal
reviewed
Feb 8, 2025
|
@siddheshzz this is conflicting with |
d8fb25d to
b32455b
Compare
Davidson-Souza
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR is realted to #358 . Fixing and removing remaining code simplification clippy warnings.
Which crates are being modified?
Description
Fixing and removing remaing code simplification clippy warnings.
No clippy warning can be seen now
Created type aliase
type PeerData = (HeaderList, BlockHashMap, BlockDataMap);forvery complex type usedwarning.Notes to the reviewers
Checklist
just lintcargo test