Skip to content

Conversation

@qlrd
Copy link
Contributor

@qlrd qlrd commented Jan 11, 2025

What is this PR for?

  • Bug fix
  • New feature
  • Docs update
  • Tests update
  • Other

Description

From #329, a comment about tests/test_framework/mock_rpc.py was made:

In the old days, before floresta could connect with actual peers, we used a client-server wire implementation. This module mimics that server, but floresta is by default built with experimental-p2p, so if you want them to connect with something you need to start a p2p server (it can either be an actual utreexod or a mocked version like core does)

So this PR remove the files:

  • tests/test_framework/mock_rpc.py;
  • tests/data/rpc/{blocks, block_index, proofs}.json

- deleted tests/test_framework/mock_rpc.py;

- deleted tests/data/rpc/{blocks, block_index, proofs}.json
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 999c39c

@Davidson-Souza Davidson-Souza merged commit b75cf0a into vinteumorg:master Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants