Improving Peer Connection Shutdown Handling #327
                
     Merged
            
            
          
      
        
          +23
        
        
          −2
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Issue #294
Problem
Our current peer connection implementation has a potential issue with connection cleanup when peers disconnect. When we split the TcpStream and run the read half in a detached task, we rely entirely on the peer's proper shutdown behavior to terminate the connection. If the peer doesn't close their connection cleanly (which appears to be happening, causing
fin-wait2states on Linux), the read task can remain active indefinitely, potentially leading to resource leaks like file descriptor exhaustion.Solution
This PR implements a cancellation pattern for more reliable connection cleanup:
tokio::select!to respond to either:Implementation Details
tokio::sync::oneshotchannel instead ofCancellationTokenfrom tokio-utils to minimize dependenciesImpact
This change should prevent connection resource leaks by ensuring read tasks are properly cleaned up, even when remote peers don't follow correct TCP shutdown procedures.