Add pre-contributing just recipe #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
ACK 8d9f124 |
JoseSK999
suggested changes
Dec 26, 2024
| ./contrib/clean_data.sh | ||
|
|
||
| # Run all needed checks before contributing code | ||
| pre-contributing: lint fmt test build-release |
There was a problem hiding this comment.
I would do this instead, as the lint recipe includes formatting, and test-features is the full check run in GitHub Actions.
Suggested change
| pre-contributing: lint fmt test build-release | |
| pc: lint test-features |
|
Omg late review 😂😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the times when contributing code to the repo I find myself only realising that I missed some linting, formatting or checking after the Github Actions job is triggered and fails.
This adds a new
justrecipe calledpre-contributingthat aims to help contributors to run a single command before opening a PR, making sure that everything is working correctly and nothing is missing.