Structure improvement functional tests #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Davidson-Souza
requested changes
Dec 17, 2024
|
Like suggested by @jaoleal, started to lint some codes (added some docstrings and did some changes on relevant warnings that the linter has accused). |
|
Nice, when the work is complete, could you squash all the commits into expressive one(s) ? |
29a3958 to
10ca7d5
Compare
|
Changed a little of code in test_framework.py (and example_test.py and restart.py) at |
|
@qlrd I think you can squash now, and I'll make a full review. Also, this needs rebase |
|
@jaoleal, @Davidson-Souza i think it's done |
|
@qlrd you have a conflict with tests/example_test.py. A rebase should fix it |
added 3 commits
December 26, 2024 18:27
…ition made on issue#252 defined python 3.12 as minimum version for functional tests
changed example_test I: added assertions at run_test
changed example_test II: added set_params method
changed restart: applied the main call at the end of file
changed run_tests: flexibilized it for individual tests
modified pyproject.toml I: added individual test tasks (example-test, restart-test)
modified pyproject.toml II: defined tests task as a sequence of individual tests
linted tests/tests_framework/{utreexod, floresta_rpc, test_framework, secp256k1, electrum_client, mock_rpc, key, bitcoin}.py
changed floresta_rpc I: diminished the number of arguments of FlorestaRPC
changed floresta_rpc II: created a default value REGTEST_RPC_SERVER
changed test_framework I: create class FlorestaTestMetaClass
changed test_framework II: renamed the class as FlorestaTestFramework
changed test_framework III: modified run_node method due to changes on tests/tests_framework/floresta.py
changed test_framework IV: added methods (set_test_params, add_node_settings, get_node_settings)
changed secp256k1 I: disabled linter on some lines
changed secp256k1 II: moved to tests/test_framework/crypto to comply with definition of modules in key.py
changed bitcoin I: added methods (dsha256, read_compact_size method, get_merkle_root method, Transaction.deserialize)
changed bitcoin II: modified Block.get_merkle_root
|
ACK 3fdb8c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
In summary, create a python structure with a
pyproject.tomlfile to:poetryand its dependencies;black;pylint;poethepoet(allowing better management for when function tests increase).