fix: specify version on just commands to avoid incorrect versions being used #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I don't think you need to specify the toolchain version. We only had this problem because we explicitly passed a 1 - A toolchain override shorthand used on the command-line, such as cargo +beta. Since our |
238fca9 to
7d6ad12
Compare
|
Nice, thats right. I tested here and everything went well. |
7d6ad12 to
4e5715c
Compare
|
ACK 4e5715c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown by lucas here #295 (comment) , #295 could be fixed aligning the versions of
cargo buildand the declared version in "rust-toolchain.toml".So i matched the version inside the justfile.I know this changes looks strange inside the justfile and possibly will be another data to maintain if we update our MSRV.But we need it, its the only way to certify such a external thing from our project.
Nope, not needed.
closes #295