CI: Test all feature combinations #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove caching from the `lint` job as it is less critical for these quick checks (now takes ~1 min). - Introduce `CACHE_VERSION` to the cache key, updated bi-weekly. - Use only release artifacts (needed to not exceed the 10GB github actions limit, but also makes sense as we test the end user targets).
c2105c2 to
4459555
Compare
|
ACK 4459555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
This PR builds on top of #276. This is a significant improvement for floresta as we will now check that no feature setup is broken and all tests pass across feature sets.
The
cargocaches used for thecross-testingjob are now smaller due toreleasebuilds (600MB macOS, 780MB Linux, 720MB Windows). While CI runtime has increased, it's still reasonable: 8–9 minutes for macOS and Linux, and 19 minutes for Windows (the slowest GitHub Actions runner).The first CI run after merging into
masterwill take longer due to cache rebuilding, but subsequent runs will align with the ~19 minutes.Commit message
lintjob as it is less critical for these quick checks (now takes ~1 min).CACHE_VERSIONto the cache key, updated bi-weekly.