Feat: refactor nix files. #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to take a different approach to how we build floresta in build.nix. Like we do now, we have to manually change info like version, which are important to be updated every new release |
jaoleal
commented
Oct 11, 2024
258bcb4 to
bbc5b9e
Compare
|
This needs a rebase |
|
Rebased. Reviewing the changes. Some readme update about nix. refactor on build.nix to receive a version of rust for building and updating info like version and maintainers. refactor on flake.nix disabling the version overriding (provides rustup instead of a specific version of the rustc and cargo toolchain.) and adding Just to the nix-shell. |
|
ACK 3c46836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253.
The problem with our nix was rust override.
After thinking a bit, its far from normal to a rust developer use more than a version of rust, so i delegated rust version control directly to rustup since it does the job better while doing development(nix-shell). just was added as a dev tool too
The build.nix had some overrides too, so i updated some meta-data and forced nix to pull rust version directly from rust-toolchain.toml. Now its easier to change dependencies.