cli: replace reqwest with jsonrpc #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reqwest pulls in a lot of dependencies, while we only need a very simple http client to make json-rpc requests. It also has ssl by default, using they installed openssl. But openssl can't be statically linked due to licensing, so if we want to build floresta for, e.g. musl, we can't build the cli tool. This commit replaces reqwest with the jsonrpc crate from rust-bitcoin, reducing the dependencies tree and making it easier to static link floresta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwest pulls in a lot of dependencies, while we only need a very simple http client to make json-rpc requests. It also has ssl by default, using they installed openssl. But openssl can't be statically linked due to licensing, so if we want to build floresta for, e.g. musl, we can't build the cli tool.
This commit replaces reqwest with the jsonrpc crate from rust-bitcoin, reducing the dependencies tree and making it easier to static link floresta