wallet: make it work without the Electrum Server #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the API for our watch-only wallet, wrapping it inside a RwLock, so all methods take a &self ref, instead of &mut self. This commit also replaces the watch-only instances in RPC and Electrum to use Arc<AddressCache> instead of Arc<RwLock<AddressCache>> (i.e. we have a lock inside the cache itself, so need to have a consumer-level lock)
This change is intended to decouple the watch-only wallet from the Electrum Server, in case the user don't want the latter. With this change, you can subscribe the wallet directly, without the need to run the Electrum Server main loop. This commit **does not** subscribe the wallet, as we still can't disable the Electrum Server, and it would be inefficient to notify both (the Electrum Server needs this notification too, so it can notify connected clients). In a future patch, we may choose whether to subscribe based on the user's choice of running an Electrum Server or not.
|
I'd consider going the other way and have the wallet as an external service. To my knowledge, the integrated wallet in Core is a source of significant pain. |
|
@Kixunil that's sorta the way I'm going here. I want to make the {electrum, jsonrpc}-server and the watch-only wallet optional. You can even use BDK as a wallet and floresta as the chain backend if you want (if you're using the rust code directly, I think you should). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow us to make the Electrum Server optional, in case you want to use the json-rpc or even use the wallet directly.