Wire: handle block filters out-of-order #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if we receive filters out of order, we'll consider that a misbehaving. But due to some weird connectivity or even how the remote node processes things, we may get those in a random order. This commit fixes that by holding the filters we've got in a BTree and only processing it after all the previous filters already got processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we receive filters out of order, we'll consider that a misbehaving. But due to some weird connectivity or even how the remote node processes things, we may get those in a random order. This commit fixes that by holding the filters we've got in a BTree and only processing it after all the previous filters already got processed.