ssl init #223
ssl init #223
Conversation
|
I think it's useful to still have the non-tls connection. Use port 50001 for non-tls and 50002 for tls |
|
@Davidson-Souza could we introduce a tag of |
|
I like having a config for the ssl that optionally disables it But almost every software I know let's you use both at the same time in different ports. I personally would like this because while some wallets (e.g. Phoenix) requires SSL. I like to make small scripts and tests on the CLI where I do the requests directly with nc. So I would benefit greatly having this option |
cc374aa to
bd2c0fc
Compare
There was a problem hiding this comment.
In general, it looks good, just a few minor changes and it should be ready to ship. The CI errors are probably due to not finding the SSL files while spawning the daemon, it should be fixed by ignoring SSL if we can't find the SSL stuff (i.e. not listening on 50002, only 50001)
5fc4f8a to
62a284e
Compare
|
CI is breaking on functional tests because it can't find the TLS files. You can just disable tls for most of those tests here. |
6ec1f0a to
17dc59b
Compare
|
Before merging, it would be useful if you squashed those commits and provided a message explaining what's new. See the latest commits on master for a reference. |
no-ssltag to run without the SSL server.