florestad: rework cli #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the subcmd `run` and makes all options top-level
JoseSK999
added a commit
to JoseSK999/Floresta
that referenced
this pull request
May 16, 2025
The last usage of the `florestad/experimental-p2p` feature was removed at vinteumorg#209. It is not used anywhere now. Also we have a `floresta-wire/pruned_utreexo_chainstate` feature which is not used either. I guess we could reintroduce it if in the future we have a non pruned chain (but maybe it is not needed since we work with trait bounds).
15 tasks
Davidson-Souza
pushed a commit
that referenced
this pull request
May 16, 2025
The last usage of the `florestad/experimental-p2p` feature was removed at #209. It is not used anywhere now. Also we have a `floresta-wire/pruned_utreexo_chainstate` feature which is not used either. I guess we could reintroduce it if in the future we have a non pruned chain (but maybe it is not needed since we work with trait bounds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the useless
runsubcmd and document all args