fix: force utreexo peers #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have 10 non-utreexo peers and we lose our last utreexo connection, we'll stop downloading blocks. With this commit, even if we have 10 peers, we allow one extra connection if we need a utreexo peer.
9f57f7f to
b6f37ea
Compare
|
But if we do need at least one utreexo peer to ibd, would not be good to only stop searching for peers after a certain amount of utreexo ones ? Even if we discart the normals while doing so. |
|
This code is not IBD only. In fact, the problem is more likely to happen inside Also, we should keep non-utreexo peers, or we risk not learning about new blocks if there's not bridges in our direct graph. |
|
Yes, but still making utreexo peers a priority a bad idea ? |
We prioritize utreexo peers if we don't have any. After that, we pick any good peer because there aren't that many utreexo peers out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have 10 non-utreexo peers and we lose our last utreexo connection, we'll stop downloading blocks. With this commit, even if we have 10 peers, we allow one extra connection if we need a utreexo peer.