-
Notifications
You must be signed in to change notification settings - Fork 70
Unit tests for floresta-chain, floresta-watch-only and functional tests for floresta-electrum. #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added unit tests for watch-only and refactored the tests in floresta-chain and wire as suggested. |
|
Updated If not, then the same components: |
|
@Davidson-Souza, please approval the workflows to run, so I can see if they are failing. |
|
@lla-dane done! |
|
@Davidson-Souza, please approve once more, clippy won't bug this time, probably. |
|
Finally, all the checks passed, @Davidson-Souza please review it, and suggest if I have to change something. |
|
@lla-dane you can run $ cargo +nightly clippy --all-targets
on your local project, with this you have the same feedback than actions without the need to push it to verify. |
yeah that's the thing!, ran that command on my end many times, didn't gave any errors, even ran all the CI checks on my fork too, for some reason they were passing on my fork, but failing on the PR by compilation errors, it was really weird :| |
* Unit tests for floresta-watch-only * Functional tests for floresta-electrum: Simulated a client and sent all kinds requests to the server and verified the responses
|
All commits are squashed into one. I guess some commits included in some previous PRs which got included when I synced my fork, also got squashed in this, |
|
It is showing diff for stuff that changed on master, if you rebase that will go away. |
|
@Davidson-Souza is this PR ready for merge ? |
|
I've left a few minor comments, shouldn't take more than a few minutes to fix. Then I think it's ready to merge. |
Its not showing any unresolved comments here, those that were there before are fixed already I think. Are there any new ones? |
Sorry, I forgot to submit |
|
@Davidson-Souza done! |
…ts for floresta-electrum. (vinteumorg#168) * * Unit tests for floretsa-chain * Unit tests for floresta-watch-only * Functional tests for floresta-electrum: Simulated a client and sent all kinds requests to the server and verified the responses
Aims to resolve #88
Added some basic unit tests for floresta-chain and address_man(p2p-wire) in floresta-wire.