Skip to content

Conversation

@a-moreira
Copy link
Contributor

No description provided.

@a-moreira a-moreira marked this pull request as ready for review December 19, 2023 23:55
@a-moreira a-moreira changed the title Add rustfmt file style: add .rustfmt.toml and justfile Dec 20, 2023
@Davidson-Souza
Copy link
Member

Maybe we can borrow some from rust-bitcoin. Not sure if all makes sense for us, though.

@a-moreira
Copy link
Contributor Author

@Davidson-Souza a good chunk of those are set as default. I think we can start with a smaller set and add more restrictions as we develop.

@Davidson-Souza
Copy link
Member

Sure, this doesn't need to be "a final spec".

What do you think about format_code_in_doc_comments? I always have a hard time formatting those manually.

@a-moreira
Copy link
Contributor Author

@Davidson-Souza that is a good one, adding now

@a-moreira a-moreira force-pushed the style/add-fmt-file-and-justfile branch 4 times, most recently from be31cf0 to 9fb6ca9 Compare December 20, 2023 18:03
@Davidson-Souza
Copy link
Member

Could you squash 09855bc and 06eb997 but only the changes in rustfmt.toml so I can reproduce it locally? Like one commit changing the linting and another actually running cargo fmt.

@a-moreira a-moreira force-pushed the style/add-fmt-file-and-justfile branch from 9fb6ca9 to 6aa29ea Compare December 20, 2023 18:38
@a-moreira
Copy link
Contributor Author

@Davidson-Souza I force-pushed two new commits with separation of concerns. Please pull again and try.

@Davidson-Souza
Copy link
Member

ack 6aa29ea

@a-moreira a-moreira merged commit 492dd3e into master Dec 20, 2023
@a-moreira a-moreira deleted the style/add-fmt-file-and-justfile branch December 20, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants