[Chore] WIP: End rpc type drifting #694
Open
+287
−405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff is messed because i did this in the worst way possible. Gonna fix it and mark it as Ready to Merge. Also, considering that both |
16 tasks
d835e2a to
48d4664
Compare
1186df4 to
ec99598
Compare
jaoleal
commented
Oct 24, 2025
ec99598 to
7f5d05f
Compare
|
Guys, the diff still a mess but its because of positioning and renaming. Marking this as RFR, ill try to search some types that we can already delegate to cc @moisesPompilio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description and Notes
We plan to move out to
corepc-types, which should end type drifting but there will be a burden to match both pipeline and response compatibility.This PR moves the rpc type definition to
floresta-rpc, being now a dependency forfloresta-node.How to verify the changes you have done?
Checks that
Types that are only needed for the server doesnt need to be moved into
floresta-rpc.Contributor Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).