cli: rename rescan to rescanblockchain #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 52dff8d |
|
Fixed the docs as well |
JoseSK999
reviewed
Jul 7, 2025
6501f8c to
83e9bcd
Compare
This is the name used in Bitcoin Core. We've renamed the server implementation (due to vinteumorg#453), but didn't change the CLI implementation. This leads to vinteumorg#554, which is fixed in this commit.
83e9bcd to
dd17e49
Compare
|
Updated with @JoseSK999's comments |
JoseSK999
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Fixes #554
This is the name used in Bitcoin Core. We've renamed the server implementation (due to #453), but didn't change the CLI implementation.