Skip to content

chore(test): remove -test suffix from test files #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

chore(test): remove -test suffix from test files #548

merged 1 commit into from
Jul 28, 2025

Conversation

@luisschwab
Copy link
Contributor

@luisschwab luisschwab commented Jul 2, 2025 •
edited
Loading

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: chore

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: tests

Closes #546.

Changelog

  • Remove -test suffixes from test files.

@luisschwab luisschwab force-pushed the chore/remove-test-postfix branch from 88062d5 to cb5b722 Compare July 2, 2025 17:53
@qlrd
Copy link
Contributor

qlrd commented Jul 2, 2025

The functional job have a false positive because none of the tests ran. The tests/run_tests.py search for -test.py suffix.

@jaoleal
Copy link
Collaborator

jaoleal commented Jul 2, 2025

This will hardly conflict with #526. This should wait and rebase after it got merged

@JoseSK999
Copy link
Contributor

JoseSK999 commented Jul 2, 2025

The functional job have a false positive because none of the tests ran. The tests/run_tests.py search for -test.py suffix.

Do we need that suffix or actually not (i.e., treat all files in the directories as tests)? @qlrd

@luisschwab luisschwab force-pushed the chore/remove-test-postfix branch from cb5b722 to ac6139d Compare July 2, 2025 19:13
@luisschwab
Copy link
Contributor Author

luisschwab commented Jul 2, 2025 •
edited
Loading

The functional job have a false positive because none of the tests ran. The tests/run_tests.py search for -test.py suffix.

Forgot to stage the file, fixed now.

@luisschwab
Copy link
Contributor Author

luisschwab commented Jul 2, 2025

The reorg-chain test is also breaking locally.

@qlrd
Copy link
Contributor

qlrd commented Jul 2, 2025

The functional job have a false positive because none of the tests ran. The tests/run_tests.py search for -test.py suffix.

Do we need that suffix or actually not (i.e., treat all files in the directories as tests)? @qlrd

I think it's ok to remove (@luisschwab talked with me before). It had -test suffix because i thought that could prevent some kind of future conflict.

@qlrd
Copy link
Contributor

qlrd commented Jul 2, 2025 •
edited
Loading

The reorg-chain test is also breaking locally.

Yup, i fixed that in #526. I will try to rebase it fast as possible (i had many conflicts with #523 and need some changes to not break so much with this one).

@luisschwab
Copy link
Contributor Author

luisschwab commented Jul 3, 2025

Yup, i fixed that in #526.

Cool, I'll rebase after it merges.

@qlrd
Copy link
Contributor

qlrd commented Jul 16, 2025

Yup, i fixed that in #526.

Cool, I'll rebase after it merges.

merged, i think we can re-start this one

@qlrd
Copy link
Contributor

qlrd commented Jul 26, 2025

you can back on this one @luisschwab

@luisschwab luisschwab force-pushed the chore/remove-test-postfix branch from ac6139d to b8a72a3 Compare July 26, 2025 17:00
@luisschwab luisschwab changed the title chore(test): remove -test postfix from test files chore(test): remove -test suffix from test files Jul 26, 2025
qlrd
qlrd suggested changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@qlrd qlrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a typo

@luisschwab luisschwab force-pushed the chore/remove-test-postfix branch from b8a72a3 to 3f5e915 Compare July 27, 2025 14:03
@luisschwab luisschwab requested a review from qlrd July 27, 2025 14:03
qlrd
qlrd approved these changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@qlrd qlrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3f5e915

Davidson-Souza
Davidson-Souza approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f5e915

@Davidson-Souza Davidson-Souza merged commit b6f223b into vinteumorg:master Jul 28, 2025
10 checks passed
@luisschwab luisschwab deleted the chore/remove-test-postfix branch July 28, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

+1 more reviewer

@qlrd qlrd qlrd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

functional tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove -test postfix from test file names

5 participants

@luisschwab @qlrd @jaoleal @JoseSK999 @Davidson-Souza