Florestad: refactor data_dir path creation
#547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. I would rename it to |
I think it can be confusing because we are not creating the directory but the path (and below we call I think we could use |
It makes sense to have the data directory creation in its own function, especially since the `Florestad::start` method is already quite long. Behavior is changed to parse the data directory with all '/' or '\' at the end trimmed. Also if no home directory is found we use `./.florestad`. Added tests.
f30d241 to
8ace492
Compare
data_dir creationdata_dir path creation
Davidson-Souza
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
ACK 8ace492
Strong concept ack for refactoring Floresta::start. I also think we need to stop panic/exit-ing and return proper error (florestad is also a library). But this is for another PR.
|
ACK 8ace492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Very simple refactor. It makes sense to have the data directory path creation in its own function, especially since the
Florestad::startmethod is already quite long.Behavior is changed to (directly) parse the data directory with all '/' or '\' at the end trimmed. Also if no home directory is found we use
./.floresta. Added tests.