Improve leaf reconstruction error handling #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaoleal
reviewed
Jul 1, 2025
Previously we were returning a simple `Error` enum with only one variant (`EmptyStack`) as leaf reconstruction error. This variant was used for cases where the script was actually not empty. I added the remaining 2 variants, and then a higher level error type that we use at `process_proof` to provide context. If we ever get any of these leaf errors, we will now see the error data debugged (the compact leaf we were trying to reconstruct, the txin, and the error kind).
74dc5d8 to
bb34803
Compare
|
Done! |
jaoleal
approved these changes
Jul 2, 2025
|
ACK bb34803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Previously we were returning a simple
Errorenum with only one variant (EmptyStack) as leaf reconstruction error. This variant was used for cases where the script was actually not empty.I added the remaining 2 variants, and then a higher level error type that we use at
process_proofto provide context.If we ever get any of these leaf errors, we will now see the error data debugged (the compact leaf we were trying to reconstruct, the txin, and the error kind).