feat: use tokio-subscriber to allow tokio-console #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, you can now use [tokio-console](https://github.com/tokio-rs/console) with florestad. Just need to build with thte `tokio-console` feature and pass `RUSTFLAGS="--cfg tokio_unstable"` to cargo
A doc explaining this step-by-step (even showing the screenshots) would be needed IMO |
|
Nice!! |
cbb8589 to
bd0794a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
With this commit, you can now use tokio-console with florestad.
Edit: Some screenshots of
tokio-consolerunning on my machine:The main screen shows all the tasks that were spawned, how many time it woken up, how long did it run, wait or blocked.
This is the resource tab, it shows all resources that
tokiois menaging (locks, files, sockets, channels...). You can toggle this view by pressingr, and go back to tasks by pressingt.This shows some info about one specific task, like a histogram of CPU usage (you can toggle this by pressing ENTER while on the main screen)
Notes to the reviewers
Install
tokio-consolewith cargo and runtokio-consolewith floresta running to use it. Then start floresta withRUSTFLAGS=--cfg tokio_unstable cargo run --release --bin florestad --features tokio-console