[RPC] Change the stop return value to be compliant wit Bitcoin Core #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b11c846 to
44719aa
Compare
|
can you retrigger the CI @qlrd |
* change return string "florestad stopping" to "Floresta stopping"; * change the string value on its unit test; * added a docstring for `stop` rpc command compliant with core.
yup, sorry, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
stopreturn message.Which crates are being modified?
Description
stoprpc command compliant with core;Notes to the reviewers
The Bitcoin Core
stoprpc command return the message'Bitcoin Core stopping'and ourstopmessage retuns a little different message ('florestad stopping').Author Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --release