Skip to content

Conversation

@qlrd
Copy link
Contributor

@qlrd qlrd commented Jun 10, 2025

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: test folder

Description

Fix #514

Notes to the reviewers

  • add --test-name option to tests/run_tests.py;
  • adapt tests/run.sh to accept --test-name argument;
  • add information about --test-name in doc/running-tests.md

Author Checklist

  • I've followed the contribution guidelines
  • I've verified one of the following:
    • Ran just pcc (recommended but slower)
    • Ran just lint-features '-- -D warnings' && cargo test --release
    • Confirmed CI passed on my fork
  • I've linked any related issue(s) in the sections above

Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@qlrd qlrd force-pushed the select-functional-test branch from fd692aa to ed386b3 Compare June 12, 2025 10:18
Fix vinteumorg#514

* add `--test-name` option to `tests/run_tests.py`;
* adapt `tests/run.sh` to accept `--test-name` argument;
* add information about `--test-name` in `doc/running-tests.md`
@qlrd qlrd force-pushed the select-functional-test branch from ed386b3 to 3d80030 Compare June 12, 2025 10:21
@qlrd qlrd requested a review from Davidson-Souza June 12, 2025 12:40
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d80030

@Davidson-Souza Davidson-Souza merged commit 88f9c1c into vinteumorg:master Jun 12, 2025
10 checks passed
@qlrd qlrd deleted the select-functional-test branch September 2, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Select named functional tests in a suite

2 participants