Skip to content

Conversation

@Davidson-Souza
Copy link
Member

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

This adds a ping rpc that sends ping to all our peers.

Notes to the reviewers

This will help fix the functional tests in #501

This request will send pings to all connected peers, and probe their
liveness.
@Davidson-Souza Davidson-Souza added enhancement New feature or request functional tests new rpc This issue/PR implements a new json-rpc endpoint RPC Changes something with our JSON-RPC interface labels Jun 4, 2025
@Davidson-Souza Davidson-Souza changed the title Rpc/ping RPC: add the ping RPC Jun 4, 2025
@Davidson-Souza Davidson-Souza mentioned this pull request Jun 4, 2025
5 tasks
Copy link
Contributor

@qlrd qlrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits

@Davidson-Souza
Copy link
Member Author

Updated with @jaoleal and @qlrd's comments.

@jaoleal
Copy link
Collaborator

jaoleal commented Jun 5, 2025

ACK 635a886

@qlrd
Copy link
Contributor

qlrd commented Jun 5, 2025

ACK 635a886

@Davidson-Souza Davidson-Souza merged commit fdc0381 into vinteumorg:master Jun 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request functional tests new rpc This issue/PR implements a new json-rpc endpoint RPC Changes something with our JSON-RPC interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants