Skip to content

Conversation

@lucad70
Copy link
Contributor

@lucad70 lucad70 commented May 23, 2025

What is the purpose of this pull request?

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

The method as is does not update the hash, so this pr modifies to update it and also adds a check for both peers lying.

Notes to the reviewers

I opted for using the "?" instead of unwrap, following the discussion on #463

Author Checklist

  • I've followed the contribution guidelines
  • I've verified one of the following:
    • Ran just pcc (recommended but slower) I did this one
    • Ran just lint-features '-- -D warnings' && cargo test --release
    • Confirmed CI passed on my fork
  • I've linked any related issue(s) in the sections above

Finally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).

@Davidson-Souza Davidson-Souza added bug Something isn't working code quality Generally improves code readability and maintainability labels May 24, 2025
@lucad70 lucad70 force-pushed the find-who-is-lying branch from 5c5978c to 3a1b28b Compare May 31, 2025 01:29
@lucad70
Copy link
Contributor Author

lucad70 commented May 31, 2025

Apparently I was again, the lucky one to get a new linting error. @Davidson-Souza

@lucad70 lucad70 mentioned this pull request Jun 2, 2025
18 tasks
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5dd7d0d

@Davidson-Souza Davidson-Souza merged commit 1ecd90b into vinteumorg:master Jun 5, 2025
10 checks passed
@lucad70 lucad70 deleted the find-who-is-lying branch July 10, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working code quality Generally improves code readability and maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants