Group chain traits #495
Merged
Group chain traits #495
+39
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e79c18d to
da7deaf
Compare
|
Seems a nice thing, in fact we use a similar trait grouping in I would use a name like Also I wouldn't replace the |
da7deaf to
6848f37
Compare
|
agreed, nice naming! applied on 6848f37 |
6848f37 to
80c6c72
Compare
JoseSK999
suggested changes
May 26, 2025
4fe2f93 to
bce7340
Compare
JoseSK999
suggested changes
May 27, 2025
There was a problem hiding this comment.
Only some final nits.
I would also replace the RpcChain trait defined in florestad/src/json_rpc/server.rs to this:
/// Utility trait to ensure that the chain in our RPC server implements all the necessary traits
pub trait RpcChain: ThreadSafeChain + Clone {}
impl<T: ThreadSafeChain + Clone> RpcChain for T {}64e1558 to
1f1f612
Compare
|
Applied @JoseSK999 suggestions |
JoseSK999
reviewed
May 27, 2025
1f1f612 to
7f5fffd
Compare
|
Applied @JoseSK999 suggestions |
JoseSK999
approved these changes
May 27, 2025
|
ACK 7f5fffd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
We rely on
BlockchainInterfaceandUpdatableChainStatetraits to define how we expect the backend chain to be but it can became kind of repetitive mentioning every single trait. This is a try to mitigate this.Notes to the reviewers
Theres other ways to to different what i did here, that is, reducing trait bounds verbosity... Thoughts ?
Author Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).