feat: BIP-0094 "testnet4" #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseSK999
suggested changes
May 28, 2025
|
Updated with @JoseSK999's comments |
|
Was this able to sync with the bridge node? |
|
I guess there is no bridge yet, I'll try to get one running over the weekend. |
It headers-synced. But I'll try with a proper bridge node here and report back. |
|
Oh actually headers sync is now testing the full change behavior |
|
I've just remembered, |
JoseSK999
suggested changes
May 30, 2025
This commit implements testnet4-related pow changes, and makes sure that all node functionalities works with it.
|
rebased after #506 and updated with @JoseSK999's comments. |
JoseSK999
approved these changes
Jun 2, 2025
|
@Davidson-Souza does your bridge work with testnet4? |
|
Answer: not really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Closes #156
This commit implements BIP-0094-related pow changes, and makes sure that all node functionalities works with it the "testnet4" network.
Note to reviwers
I've managed to headers-sync, but didn't download blocks due to no bridges so far. I'll try to get one running