Update the log crate
#485
Merged
Update the log crate
#485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating the `log` crate, the same linting problem that was fixed in vinteumorg#459 now appeared inside the log macros, namely: ```rust log!("Something went wrong {:?}", what_happened); ``` Will issue an warning because this could be re-written as ```rust log!("Something went wrong {what_happened:?}"); ``` this is the first commit in a sequence to fix those problems.
Same as `f15dd346587803831fee79b28badf5b8324ca092`, but for floresta-wire
Same as `f15dd346587803831fee79b28badf5b8324ca092`, but for floresta-electrum.
Same as `f15dd346587803831fee79b28badf5b8324ca092`, but for floresta-wire
Same as `f15dd346587803831fee79b28badf5b8324ca092`, but for floresta-wire
|
ACK 0089e4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Depends on #483This continues with the dependency bump, now it's the
logcrate. I've also had to fix some linting error introduced after the bump. Each subcrate is handled on separated commits.