feat: add BIP30 check #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c103f9 to
9dc28dd
Compare
|
ACK 9dc28dd |
JoseSK999
reviewed
May 13, 2025
JoseSK999
reviewed
May 13, 2025
9dc28dd to
78970f9
Compare
JoseSK999
approved these changes
May 13, 2025
lucad70
pushed a commit
to lucad70/Floresta
that referenced
this pull request
May 15, 2025
This is almost a carbon copy of the stale vinteumorg#120 minus comment modifications. Coinbase transactions from blocks 91_722 and 91_812 have identical TXIDs to previous transactions. This PR marks them as unspendable by checking if any of del_hashes matches one of these UTXOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
This is almost a carbon copy of the stale #120 minus comment modifications.
Coinbase transactions from blocks 91_722 and 91_812 have identical TXIDs to previous transactions. This PR marks them
as unspendable by checking if any of
del_hashesmatches one of these UTXOs.Author Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --release