[Rpcsaga] add blockhash to gettxoutproof #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
requested changes
May 7, 2025
9ff7536 to
9a8bed0
Compare
|
Applied @Davidson-Souza requests and rewrote the commit message, now appears to better explain whats being done here. Refer to the PR description to read the last commit message |
9a8bed0 to
a336c21
Compare
|
Applied @Davidson-Souza s suggestions. (#472 (comment)) |
bfd35e8 to
32699d5
Compare
127f778 to
248ceef
Compare
jaoleal
commented
May 14, 2025
248ceef to
19d5ff7
Compare
|
332e69d, made the command succeed exactly with cores api, you can check this by yourself. floresta-cli gettxoutproof '["5a4ebf66822b0b2d56bd9dc64ece0bc38ee7844a23ff1d7320a88c5fdb2ad3e2"]' 000000000043a8c0fd1d6f726790caa2a406010d19efd2780db27bdbbd93baf6
"01000000ba8b9cda965dd8e536670f9ddec10e53aab14b20bacad27b9137190000000000190760b278fe7b8565fda3b968b918d5fd997f993b23674c0af3b6fde300b38f33a5914ce6ed5b1b01e32f570200000002252bf9d75c4f481ebb6278d708257d1f12beb6dd30301d26c623f789b2ba6fc0e2d32adb5f8ca820731dff234a84e78ec30bce4ec69dbd562d0b2b8266bf4e5a0105"and this is from a bitcoin core node (Im using a gambiarra with jq and a public node) [nix-shell:~]$ btc-rpc gettxoutproof '["5a4ebf66822b0b2d56bd9dc64ece0bc38ee7844a23ff1d7320a88c5fdb2ad3e2"]' 000000000043a8c0fd1d6f726790caa2a406010d19efd2780db27bdbbd93baf6
{
"jsonrpc": "2.0",
"id": "curl",
"result": "01000000ba8b9cda965dd8e536670f9ddec10e53aab14b20bacad27b9137190000000000190760b278fe7b8565fda3b968b918d5fd997f993b23674c0af3b6fde300b38f33a5914ce6ed5b1b01e32f570200000002252bf9d75c4f481ebb6278d708257d1f12beb6dd30301d26c623f789b2ba6fc0e2d32adb5f8ca820731dff234a84e78ec30bce4ec69dbd562d0b2b8266bf4e5a0105"
} |
19d5ff7 to
332e69d
Compare
Davidson-Souza
requested changes
May 16, 2025
082929c to
adeface
Compare
d3e0c53 to
f50525d
Compare
|
Added @Davidson-Souza Suggestions on f50525d |
f50525d to
64b0536
Compare
|
Added @Davidson-Souza Suggestions on 64b0536 |
39a78fb to
ae109bd
Compare
|
signed and retriggered the buggy CI |
ae109bd to
8cf8de4
Compare
|
Noooow its done, forgot to exclude floresta-cli from |
8cf8de4 to
a7047df
Compare
Davidson-Souza
requested changes
May 20, 2025
4101b88 to
0dcba9c
Compare
JoseSK999
reviewed
May 21, 2025
a7d7a60 to
e60d583
Compare
Yes, strange... The change now is being triggered by lint, not by me. Applied @Davidson-Souza suggestions in e60d583 |
This commit present some changes for gettxoutproof, adding the optional blockhash input which will make the method interns differ, searching for the transactions inside the specified block, otherwise, the previous default behavior of getting it from the wallet cache remains. The method now receives an array of txids instead of just one. A unused #[allow(unused)] was also removed from merkle.rs Also, now named gettxoutproof, was gettxproof.
e60d583 to
aebb3ac
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Fix #378
This commit present some changes for gettxoutproof, adding the optional blockhash
input which will make the method interns differ, searching for the transactions
inside the specified block, otherwise, the previous default behavior of getting it
from the wallet cache remains. The method now receives an array of txids instead of
just one.
Also, now named gettxoutproof, was gettxproof.
A unused #[allow(unused)] was also removed from merkle.rs
Notes to the reviewers
While trying to fork and just complete #379 to accomplish one of
0.8.0 milestonesi noticed some opportunities to optimize some decisions and add two new fixes to the #378 issue. (1. and 2.)Still validating if the changes are effective and are working.
Author Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).