wire: Rework dns seeds #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbce4c0 to
e49681f
Compare
|
Rebased with master after #454. Marking as ready for review. |
Yeah currently we always use the OS DNS resolver (via the |
jaoleal
approved these changes
May 1, 2025
e49681f to
1bdde83
Compare
|
Updated with @jaoleal's comments |
|
ack 1bdde83 |
JoseSK999
reviewed
May 2, 2025
1bdde83 to
20243d7
Compare
JoseSK999
suggested changes
May 3, 2025
20243d7 to
7cb4cc6
Compare
|
Updated with @JoseSK999's comments. |
JoseSK999
reviewed
May 3, 2025
The current code for dns seeds is very frustrating: it asks for addresses even when we don't need, it takes a while to return (holding the node meanwhile), can't be disabled. This commit reworks that to fix those problems. The dns seed code now only runs after we've been more than one minute and we haven't seen at least one connection. It runs on the background and notifies the node back one it's finished. I've also added an option to disable the dns seeds. This could be useful for privacy reasons (don't want to leak to my dns provider that I use bitcoin).
7cb4cc6 to
9264e5c
Compare
JoseSK999
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Depends on #454
The current code for dns seeds is very frustrating: it asks for
addresses even when we don't need, it takes a while to return (holding
the node meanwhile), can't be disabled.
This commit reworks that to fix those problems. The dns seed code now
only runs after we've been more than one minute and we haven't seen at
least one connection. It runs on the background and notifies the node
back one it's finished.
I've also added an option to disable the dns
seeds. This could be useful for privacy reasons (don't want to leak to
my dns provider that I use bitcoin).
Checklist
just lintcargo test