Add coinbase maturity tests (historical txs) #457
Merged
+95
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two historical cases: - A coinbase output spent at `n + 101` - A coinbase output spent at `n + 100` Then we tweak the height for the last case to test the negative case, failing if spent at `n + 99` (not matured). And a nit: Aligned better the `TX_VALIDATION_CASES_LEGACY` array, adding a tab.
Davidson-Souza
added a commit
to Davidson-Souza/Floresta
that referenced
this pull request
Apr 28, 2025
\vinteumorg#457 introduced a change that broke a new lint for string interpolation. For some reason, it didn't break on the PR itself, but did break after merge. This commit fixes it and should get CI green again.
21 tasks
Davidson-Souza
added a commit
that referenced
this pull request
Apr 28, 2025
#457 introduced a change that broke a new lint for string interpolation. For some reason, it didn't break on the PR itself, but did break after merge. This commit fixes it and should get CI green again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
This adds two historical cases:
n + 101(see the tx and the outspend heights)n + 100(see the tx and the outspend heights)Then we tweak the height for the last case to test the negative case, failing if spent at
n + 99(not matured).And a nit: Aligned better the
TX_VALIDATION_CASES_LEGACYarray, adding a tab.Notes to the reviewers
Test follow up for #440.
Fun fact: I couldn't find coinbase coins spent in the minimum block allowed (
n + 100) anywhere online. I had to traverse the whole first 228k blocks to find the first historical examples of these spends.