Skip to content

Generalizing test_framework to allow utreexod in integration tests #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

Generalizing test_framework to allow utreexod in integration tests #452

merged 4 commits into from
Apr 28, 2025

Conversation

@qlrd
Copy link
Contributor

@qlrd qlrd commented Apr 18, 2025

Fix #449

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: tests .

Description

This PR generalize the the test_framework on sub-libraries to allow
this and future implementations, so new daemons/rpcs from different implementations
can be used in a easier way.

Notes to the reviewers

This PR is a followup of #448, aiming for a concise test_framework.

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@qlrd qlrd force-pushed the integrate-utreexod-test branch 2 times, most recently from 5efc59b to 59c9793 Compare April 18, 2025 16:59
@qlrd qlrd changed the title Generalizing test_framework to allow utreexod in implementation tests Generalizing test_framework to allow utreexod in integration tests Apr 18, 2025
@Davidson-Souza Davidson-Souza added enhancement New feature or request chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability functional tests labels Apr 18, 2025
Davidson-Souza
Davidson-Souza requested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all: this is a pretty impressive work! Our test infrastructure is getting incredibly powerful and robust.

I'm leaving some minor code review comments here. I'll test it locally and report back

@qlrd qlrd force-pushed the integrate-utreexod-test branch from 59c9793 to f363ed8 Compare April 22, 2025 13:40
@qlrd qlrd mentioned this pull request Apr 22, 2025
Merged
21 tasks
@qlrd
Copy link
Contributor Author

qlrd commented Apr 23, 2025

Need some rebasing, i will try resolve conflicts here

@qlrd qlrd force-pushed the integrate-utreexod-test branch 3 times, most recently from a405bcb to 88e88e2 Compare April 24, 2025 12:54
@qlrd
Copy link
Contributor Author

qlrd commented Apr 24, 2025

Rebased on top of #446 but the clippy broked

This was referenced Apr 24, 2025
Closed
Merged
qlrd added 3 commits April 24, 2025 14:36
@qlrd
Refactored test_framework to allow integration tests.
b310a6e 
Fix vinteumorg#449

This commit generalize the the test_framework on sub-libraries to allow
this and future implementations, for different daemons and JSONRPCs:

* simplified import of test_framework by renaming
tests/test_framework/test_framework.py to
tests/test_framework/__init__.py;
* codebase for daemons (base-daemon, florestad-daemon, utreexod-daemon);
* codebase for json-rpc (base-rpc, floresta-rpc, utreexo-rpc);
* codebase for client (base-client, electrum-client).
@qlrd
Applied test_framework changes to exemplary tests:
2697981 
* floresta JSONRpc (functional);
* integrated floresta's electrum (functional);
* original utreexo implementation  (functional/integration);
* utreexo/floresta JSONRpc(s) (integration).
@qlrd
Applied test_framework changes to florestad:
bfad56f 
* restart test;
* ssl test;
* ssl failure test.
@qlrd qlrd force-pushed the integrate-utreexod-test branch from 88e88e2 to f56c5c1 Compare April 24, 2025 17:37
@qlrd
Applied test_framework changes to floresta-cli:
ad609df 
* addnode;
* getblock;
* getblockchaininfo;
* getblockhash;
* getblockheader;
* getmemoryinfo;
* getpeerinfo;
* getroots;
* stop;
* uptime.
@qlrd qlrd force-pushed the integrate-utreexod-test branch from f56c5c1 to ad609df Compare April 24, 2025 19:55
@qlrd qlrd requested a review from Davidson-Souza April 24, 2025 20:54
Davidson-Souza
Davidson-Souza approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ad609df

@qlrd
Copy link
Contributor Author

qlrd commented Apr 25, 2025 •
edited
Loading

Bitcoin-Core's addnode have 3 arguments, 2 of them required and third optional (addnode "node" "command" ( v2transport )).

@qlrd qlrd requested a review from Davidson-Souza April 28, 2025 10:49
@Davidson-Souza Davidson-Souza merged commit 0f4a5ab into vinteumorg:master Apr 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Awaiting requested review from Davidson-Souza

Assignees

No one assigned

Labels

chore Cleaning, refactoring, reducing complexity code quality Generally improves code readability and maintainability enhancement New feature or request functional tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Concise structure for daemons and rpcs that could be sub-classed;

2 participants

@qlrd @Davidson-Souza